Merge pull request #2279 in SNORT/snort3 from ~KATHARVE/snort3:checksum_tests to...

Squashed commit of the following:

commit aa5f26c07561becdaf490d0a645ed664508b72b3
Author: Katura Harvey <katharve@cisco.com>
Date:   Mon Jun 22 23:52:43 2020 -0400

    detection: remove checksum drop fixit

diff --git a/src/detection/detection_engine.cc b/src/detection/detection_engine.cc
index 14bb099201a195d7bcfc1e447fc92d5300de4c47..95ded1d8727663f89a96e97cbaa3385353de0859 100644 (file)
--- a/src/detection/detection_engine.cc
+++ b/src/detection/detection_engine.cc
@@ -576,8 +576,8 @@ bool DetectionEngine::inspect(Packet* p)
         if ( p->ptrs.decode_flags & DECODE_ERR_FLAGS )
         {
             if ( p->context->conf->inline_mode() and
-                // FIXIT-H check specific proto checksum drop flags
-                snort::get_network_policy()->checksum_drops(p->ptrs.decode_flags & DECODE_ERR_CKSUM_ALL) )
+                snort::get_network_policy()->checksum_drops(p->ptrs.decode_flags &
+                    DECODE_ERR_CKSUM_ALL) )
             {
                 p->active->drop_packet(p);
             }