]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
libsmb: Use SMB2_0_INFO_ constants instead of magic numbers
authorVolker Lendecke <vl@samba.org>
Fri, 17 May 2024 10:32:20 +0000 (12:32 +0200)
committerAndrew Bartlett <abartlet@samba.org>
Wed, 22 May 2024 04:23:29 +0000 (04:23 +0000)
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source3/libsmb/cli_smb2_fnum.c
source3/libsmb/clifile.c
source3/libsmb/clirap.c

index 099ba44597ccecd15f2bf93206130c4e09741118..7f44435963f7e625fd6987ea7b680314fbd6d7c4 100644 (file)
@@ -2431,7 +2431,7 @@ NTSTATUS cli_smb2_setatr(struct cli_state *cli,
        return cli_smb2_setpathinfo(
                cli,
                name,
-               1,                           /* in_info_type */
+               SMB2_0_INFO_FILE,            /* in_info_type */
                FSCC_FILE_BASIC_INFORMATION, /* in_file_info_class */
                &inbuf);
 }
@@ -2480,7 +2480,7 @@ NTSTATUS cli_smb2_setattrE(struct cli_state *cli,
        status = cli_smb2_set_info_fnum(
                cli,
                fnum,
-               1,                           /* in_info_type */
+               SMB2_0_INFO_FILE,            /* in_info_type */
                FSCC_FILE_BASIC_INFORMATION, /* in_file_info_class */
                &inbuf,                      /* in_input_buffer */
                0);                          /* in_additional_info */
@@ -3149,7 +3149,7 @@ static struct tevent_req *cli_smb2_rename_fnum_send(
                ev,                           /* ev */
                cli,                          /* cli */
                fnum,                         /* fnum */
-               1,                            /* in_info_type */
+               SMB2_0_INFO_FILE,             /* in_info_type */
                FSCC_FILE_RENAME_INFORMATION, /* in_file_info_class */
                &state->inbuf,                /* in_input_buffer */
                0);                           /* in_additional_info */
@@ -3365,7 +3365,7 @@ NTSTATUS cli_smb2_set_ea_fnum(struct cli_state *cli,
        status = cli_smb2_set_info_fnum(
                cli,
                fnum,
-               1,                             /* in_info_type */
+               SMB2_0_INFO_FILE,              /* in_info_type */
                FSCC_FILE_FULL_EA_INFORMATION, /* in_file_info_class */
                &inbuf,                        /* in_input_buffer */
                0);                            /* in_additional_info */
@@ -3474,7 +3474,7 @@ NTSTATUS cli_smb2_get_ea_list_path(struct cli_state *cli,
        status = cli_smb2_query_info_fnum(
                cli,
                fnum,
-               1,                             /* in_info_type */
+               SMB2_0_INFO_FILE,              /* in_info_type */
                FSCC_FILE_FULL_EA_INFORMATION, /* in_file_info_class */
                0xFFFF,                        /* in_max_output_length */
                NULL,                          /* in_input_buffer */
@@ -3726,7 +3726,7 @@ NTSTATUS cli_smb2_get_fs_quota_info(struct cli_state *cli,
        status = cli_smb2_query_info_fnum(
                cli,
                quota_fnum,
-               2,                         /* in_info_type */
+               SMB2_0_INFO_FILESYSTEM,    /* in_info_type */
                FSCC_FS_QUOTA_INFORMATION, /* in_file_info_class */
                0xFFFF,                    /* in_max_output_length */
                NULL,                      /* in_input_buffer */
@@ -3814,7 +3814,7 @@ NTSTATUS cli_smb2_set_fs_quota_info(struct cli_state *cli,
        status = cli_smb2_set_info_fnum(
                cli,
                quota_fnum,
-               2,                         /* in_info_type */
+               SMB2_0_INFO_FILESYSTEM,    /* in_info_type */
                FSCC_FS_QUOTA_INFORMATION, /* in_file_info_class */
                &inbuf,                    /* in_input_buffer */
                0);                        /* in_additional_info */
@@ -4722,7 +4722,7 @@ NTSTATUS cli_smb2_ftruncate(struct cli_state *cli,
        status = cli_smb2_set_info_fnum(
                cli,
                fnum,
-               1,                                 /* in_info_type */
+               SMB2_0_INFO_FILE,                  /* in_info_type */
                FSCC_FILE_END_OF_FILE_INFORMATION, /* in_file_info_class */
                &inbuf,                            /* in_input_buffer */
                0);
index edbc21bc3c32302f8c2accbce2010d43a09e80cd..7732cb9127907eeb42a83185e262fe1a8860dfd3 100644 (file)
@@ -2026,7 +2026,7 @@ static void cli_smb2_hardlink_opened(struct tevent_req *subreq)
                state->ev,
                state->cli,
                state->fnum_src,
-               1,                          /* in_info_type */
+               SMB2_0_INFO_FILE,           /* in_info_type */
                FSCC_FILE_LINK_INFORMATION, /* in_file_info_class */
                &inbuf,
                0); /* in_additional_info */
index b25f6832273c8800acbce30e0f12624834bcd179..ffc643625c9eb5dd304e841f98c6fcae359f2317 100644 (file)
@@ -626,7 +626,7 @@ NTSTATUS cli_setpathinfo_ext(struct cli_state *cli, const char *fname,
                 */
                return cli_smb2_setpathinfo(cli,
                                            fname,
-                                           1, /* SMB2_SETINFO_FILE */
+                                           SMB2_0_INFO_FILE,
                                            FSCC_FILE_BASIC_INFORMATION,
                                            &in_data);
        }