]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
spec: add dmidecode as prereq
authorEric Blake <eblake@redhat.com>
Mon, 5 Dec 2011 17:32:41 +0000 (10:32 -0700)
committerEric Blake <eblake@redhat.com>
Mon, 5 Dec 2011 18:00:45 +0000 (11:00 -0700)
https://bugzilla.redhat.com/show_bug.cgi?id=754909 complains that
because libvirt didn't require dmidecode, that the logs are noisy
and virConnectGetSysinfo needlessly fails.  Even 'virt-what' requires
dmidecode, so it's not that onerous of a dependency.  We may be
able to drop this in the future when we move to parsing sysfs data,
but for now, listing the dependency will help matters.

* libvirt.spec.in (Requires): Sort Requires before BuildRequires.
Add dmidecode.

libvirt.spec.in

index 06c949b4fc742a4a75f72a5723bcc3eda1c40088..dc8ed756aede3b513ff7ee29f1506c41f551eb1a 100644 (file)
@@ -332,6 +332,15 @@ Requires: device-mapper
 %if %{with_cgconfig}
 Requires: libcgroup
 %endif
+# For virConnectGetSysinfo
+Requires: dmidecode
+# For service management
+%if %{with_systemd}
+Requires(post): systemd-units
+Requires(post): systemd-sysv
+Requires(preun): systemd-units
+Requires(postun): systemd-units
+%endif
 
 # All build-time requirements
 BuildRequires: python-devel
@@ -482,13 +491,6 @@ BuildRequires: nfs-utils
 # Fedora build root suckage
 BuildRequires: gawk
 
-%if %{with_systemd}
-Requires(post): systemd-units
-Requires(post): systemd-sysv
-Requires(preun): systemd-units
-Requires(postun): systemd-units
-%endif
-
 %description
 Libvirt is a C toolkit to interact with the virtualization capabilities
 of recent versions of Linux (and other OSes). The main package includes