The TSIG algorithm was being passed to use_tsig() incorrectly.

diff --git a/ChangeLog b/ChangeLog
index 37f62ea85faf1816c4c8ee67925da108c7bd4295..73a66edef68ca86dd362791e1e5029310f9a9d40 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2010-03-10  Bob Halley  <halley@dnspython.org>
+
+       * The TSIG algorithm value was passed to use_tsig() incorrectly
+         in some cases.  Thanks to 'ducciovigolo' for reporting the problem.
+
 2010-01-26  Bob Halley  <halley@dnspython.org>
 
        * (Version 1.8.0 released)

diff --git a/dns/resolver.py b/dns/resolver.py
index 372d7d83615b9474e0a1e4594e6eae375d99d4f6..cd0e5f804bc70acf90416edb4bb8fc2e25b653c5 100644 (file)
--- a/dns/resolver.py
+++ b/dns/resolver.py
@@ -593,7 +593,8 @@ class Resolver(object):
                     return answer
             request = dns.message.make_query(qname, rdtype, rdclass)
             if not self.keyname is None:
-                request.use_tsig(self.keyring, self.keyname, self.keyalgorithm)
+                request.use_tsig(self.keyring, self.keyname,
+                                 algorithm=self.keyalgorithm)
             request.use_edns(self.edns, self.ednsflags, self.payload)
             response = None
             #

diff --git a/dns/update.py b/dns/update.py
index 7d4263689170574fdde5df4cfed2bf0b20556df8..97aea18fb9cbdd3549869bf3997917670196767f 100644 (file)
--- a/dns/update.py
+++ b/dns/update.py
@@ -56,7 +56,7 @@ class Update(dns.message.Message):
         self.find_rrset(self.question, self.origin, rdclass, dns.rdatatype.SOA,
                         create=True, force_unique=True)
         if not keyring is None:
-            self.use_tsig(keyring, keyname, keyalgorithm)
+            self.use_tsig(keyring, keyname, algorithm=keyalgorithm)
 
     def _add_rr(self, name, ttl, rd, deleting=None, section=None):
         """Add a single RR to the update section."""