]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
iovec: make sure the caller actually wants anything in memcpy_fromiovecend
authorSasha Levin <sasha.levin@oracle.com>
Fri, 1 Aug 2014 03:00:35 +0000 (23:00 -0400)
committerWilly Tarreau <w@1wt.eu>
Sun, 23 Nov 2014 09:55:43 +0000 (10:55 +0100)
[ Upstream commit 06ebb06d49486676272a3c030bfeef4bd969a8e6 ]

Check for cases when the caller requests 0 bytes instead of running off
and dereferencing potentially invalid iovecs.

Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Willy Tarreau <w@1wt.eu>
net/core/iovec.c

index 3face248258eb9cd534ccd8a22ab139dde8e31b6..5ca2fa8f423ec9ac9b33f0ae8e376426513c789c 100644 (file)
@@ -153,6 +153,10 @@ int memcpy_fromiovec(unsigned char *kdata, struct iovec *iov, int len)
 int memcpy_fromiovecend(unsigned char *kdata, const struct iovec *iov,
                        int offset, int len)
 {
+       /* No data? Done! */
+       if (len == 0)
+               return 0;
+
        /* Skip over the finished iovecs */
        while (offset >= iov->iov_len) {
                offset -= iov->iov_len;