]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commitdiff
remove __getitem__ method from ClauseList
authorJoshua Morris <joshua.morris@deswik.com>
Thu, 8 Jun 2023 22:46:26 +0000 (08:46 +1000)
committerJoshua Morris <joshua.morris@deswik.com>
Mon, 10 Jul 2023 22:48:07 +0000 (08:48 +1000)
lib/sqlalchemy/dialects/mysql/base.py
lib/sqlalchemy/sql/elements.py

index 8c77f1c585ac9fa5d0f4213e60971db6bf7d09b0..ac16904279fabdd6ab7194b528661a6ee674b43f 100644 (file)
@@ -1210,13 +1210,11 @@ class MySQLCompiler(compiler.SQLCompiler):
 
     def visit_string_agg_func(self, fn, **kw):
         if len(fn.clauses) > 1:
-            clause = ", ".join(
-                elem._compiler_dispatch(self, **kw) for elem in fn.clauses[:-1]
-            )
-            return "group_concat(%s SEPARATOR %s)" % (
-                clause,
-                fn.clauses[-1]._compiler_dispatch(self, **kw),
-            )
+            clauses = [
+                elem._compiler_dispatch(self, **kw) for elem in fn.clauses
+            ]
+            clause = ", ".join(clauses[:-1])
+            return "group_concat(%s SEPARATOR %s)" % (clause, clauses[-1])
         else:
             return "group_concat%s" % self.function_argspec(fn)
 
index ad5fcde1ae90d42b4729a3bb68c59ce955e4b523..ba074db80c6ec11de4031f8f5ca0452883622387 100644 (file)
@@ -2766,9 +2766,6 @@ class ClauseList(
         self._is_implicitly_boolean = False
         return self
 
-    def __getitem__(self, item) -> ColumnElement[Any]:
-        return self.clauses[item]
-
     def __iter__(self) -> Iterator[ColumnElement[Any]]:
         return iter(self.clauses)