ila: fix potential snprintf buffer overflow

The code to print 64 bit address has a theoretical overflow
of snprintf buffer found by CodeQL scan.
Address by checking result.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

diff --git a/ip/ipila.c b/ip/ipila.c
index 4f6d578f24ae7ff378abd4867658c666785ae085..23b19a108862a02c61c201c5bc267fab237b3fcc 100644 (file)
--- a/ip/ipila.c
+++ b/ip/ipila.c
@@ -60,6 +60,8 @@ static void print_addr64(__u64 addr, char *buff, size_t len)
                        sep = "";
 
                ret = snprintf(&buff[written], len - written, "%x%s", v, sep);
+               if (ret < 0 || ret >= len - written)
+                       break;
                written += ret;
        }
 }