virSCSIHostFindByPCI: Fix link detection

Inside of virSCSIHostFindByPCI() there's a loop which iterates of
entries of "/sys/class/scsi_host" directory trying to identify
all symlinks (which then point to a SCSI device, but that's not
important right now). But the way virFileIsLink() is called can
never return a truthful reply - because it's called over
dent->d_name instead of full path. Fix this by moving the
virFileIsLink() call and passing constructed path into it.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>

diff --git a/src/util/virscsihost.c b/src/util/virscsihost.c
index 014b96452c2d677332e554e58e4ca513b071e06f..32d7f2312f73c57427804ec17d0124a696e810b2 100644 (file)
--- a/src/util/virscsihost.c
+++ b/src/util/virscsihost.c
@@ -107,11 +107,11 @@ virSCSIHostFindByPCI(const char *sysfs_prefix,
         char *p = NULL;
         unsigned int read_unique_id;
 
-        if (!virFileIsLink(entry->d_name))
-            continue;
-
         host_link = g_strdup_printf("%s/%s", prefix, entry->d_name);
 
+        if (!virFileIsLink(host_link))
+            continue;
+
         if (virFileResolveLink(host_link, &host_path) < 0)
             return NULL;