]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
clk: sunxi-ng: v3s: Fix de clock definition
authorPaul Kocialkowski <paulk@sys-base.io>
Fri, 4 Jul 2025 15:40:07 +0000 (17:40 +0200)
committerChen-Yu Tsai <wens@csie.org>
Mon, 14 Jul 2025 03:51:14 +0000 (11:51 +0800)
The de clock is marked with CLK_SET_RATE_PARENT, which is really not
necessary (as confirmed from experimentation) and significantly
restricts flexibility for other clocks using the same parent.

In addition the source selection (parent) field is marked as using
2 bits, when it the documentation reports that it uses 3.

Fix both issues in the de clock definition.

Fixes: d0f11d14b0bc ("clk: sunxi-ng: add support for V3s CCU")
Signed-off-by: Paul Kocialkowski <paulk@sys-base.io>
Link: https://patch.msgid.link/20250704154008.3463257-1-paulk@sys-base.io
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
drivers/clk/sunxi-ng/ccu-sun8i-v3s.c

index 579a81bb46df39042136965f47468f3444359ed9..7744fc632ea6d1582cab8d4822e85180a725a804 100644 (file)
@@ -347,8 +347,7 @@ static SUNXI_CCU_GATE(dram_ohci_clk,        "dram-ohci",    "dram",
 
 static const char * const de_parents[] = { "pll-video", "pll-periph0" };
 static SUNXI_CCU_M_WITH_MUX_GATE(de_clk, "de", de_parents,
-                                0x104, 0, 4, 24, 2, BIT(31),
-                                CLK_SET_RATE_PARENT);
+                                0x104, 0, 4, 24, 3, BIT(31), 0);
 
 static const char * const tcon_parents[] = { "pll-video" };
 static SUNXI_CCU_M_WITH_MUX_GATE(tcon_clk, "tcon", tcon_parents,