]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
Silence unchecked return of dns_db_find()
authorMark Andrews <marka@isc.org>
Thu, 6 Feb 2020 00:02:55 +0000 (11:02 +1100)
committerMark Andrews <marka@isc.org>
Fri, 7 Feb 2020 08:56:52 +0000 (08:56 +0000)
190        dns_rdataset_init(&rdataset);
    3. Condition r == 0, taking true branch.
    4. Condition result, taking false branch.

CID 1452691 (#1 of 1): Unchecked return value (CHECKED_RETURN)
5. check_return: Calling dns_db_find without checking return
value (as is done elsewhere 39 out of 45 times).

191        check_assertion(dns_db_find(db1, dns_rootname, v2,
192                                    dns_rdatatype_soa, 0, 0, NULL,
193                                    name, &rdataset, NULL));

lib/dns/tests/dbversion_test.c

index 79272735ca6b33b92aafdfb2b5fe51ede8669181..2046e8ce68cbf6a98d6c90450103044ca90c9e99 100644 (file)
@@ -186,9 +186,9 @@ find(void **state) {
        }
 
        dns_rdataset_init(&rdataset);
-       check_assertion(dns_db_find(db1, dns_rootname, v2,
-                                   dns_rdatatype_soa, 0, 0, NULL,
-                                   name, &rdataset, NULL));
+       check_assertion((void)dns_db_find(db1, dns_rootname, v2,
+                                         dns_rdatatype_soa, 0, 0, NULL,
+                                         name, &rdataset, NULL));
 }
 
 /*