upstream: asprintf returns -1, not an arbitrary value < 0. Also

upon error the (very sloppy specification) leaves an undefined value in *ret,
so it is wrong to inspect it, the error condition is enough. discussed a
little with nicm, and then much more with millert until we were exasperated

OpenBSD-Commit-ID: 29258fa51edf8115d244b9d4b84028487bf8923e

diff --git a/auth2.c b/auth2.c
index 16ae1a3635e5f916020fd9f756ea62cfbd3ffffc..9b08757ae48f74a536222f062b066f891250256a 100644 (file)
--- a/auth2.c
+++ b/auth2.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: auth2.c,v 1.155 2019/03/25 22:34:52 djm Exp $ */
+/* $OpenBSD: auth2.c,v 1.156 2019/06/28 05:44:09 deraadt Exp $ */
 /*
  * Copyright (c) 2000 Markus Friedl.  All rights reserved.
  *
@@ -717,7 +717,7 @@ auth2_record_info(Authctxt *authctxt, const char *fmt, ...)
        i = vasprintf(&authctxt->auth_method_info, fmt, ap);
        va_end(ap);
 
-       if (i < 0 || authctxt->auth_method_info == NULL)
+       if (i == -1)
                fatal("%s: vasprintf failed", __func__);
 }