auth: test-mech - The OTP mechanism no longer logs errors for client protocol violations

Yet, we forgot to amend this test. It only failed in Valgrind.

diff --git a/src/auth/test-mech.c b/src/auth/test-mech.c
index b1a177103f6703de9be280daa9934b6661bbf339..1d114f4b698bd09a78f5dd5e4c19e4f0c7f82a63 100644 (file)
--- a/src/auth/test-mech.c
+++ b/src/auth/test-mech.c
@@ -209,8 +209,8 @@ static void test_mechs(void)
                {"EXTERNAL", UCHAR_LEN(""), "testuser", NULL, FALSE, TRUE, FALSE},
                {"EXTERNAL", UCHAR_LEN(""), NULL, NULL, FALSE, FALSE, FALSE},
                {"LOGIN", UCHAR_LEN(""), NULL, NULL, FALSE, FALSE, FALSE},
-               {"OTP", UCHAR_LEN(""), NULL, "invalid input", FALSE, FALSE, FALSE},
-               {"OTP", UCHAR_LEN(""), "testuser", "invalid input", FALSE, FALSE, FALSE},
+               {"OTP", UCHAR_LEN(""), NULL, NULL, FALSE, FALSE, FALSE},
+               {"OTP", UCHAR_LEN(""), "testuser", NULL, FALSE, FALSE, FALSE},
                {"PLAIN", UCHAR_LEN(""), NULL, NULL, FALSE, FALSE, FALSE},
                {"OAUTHBEARER", UCHAR_LEN(""), NULL, NULL, FALSE, FALSE, FALSE},
                {"XOAUTH2", UCHAR_LEN(""), NULL, NULL, FALSE, FALSE, FALSE},
@@ -222,7 +222,7 @@ static void test_mechs(void)
                {"APOP", UCHAR_LEN("1.1.1\0testuser\0tooshort"), NULL, NULL, FALSE, FALSE, FALSE},
                {"APOP", UCHAR_LEN("1.1.1\0testuser\0responseoflen16-"), NULL, NULL, FALSE, FALSE, FALSE},
                {"APOP", UCHAR_LEN("1.1.1"), NULL, NULL, FALSE, FALSE, FALSE},
-               {"OTP", UCHAR_LEN("somebody\0testuser"), "testuser", "unsupported response type", FALSE, TRUE, FALSE},
+               {"OTP", UCHAR_LEN("somebody\0testuser"), "testuser", NULL, FALSE, TRUE, FALSE},
                {"CRAM-MD5", UCHAR_LEN("testuser\0response"), "testuser", NULL, FALSE, FALSE, FALSE},
                {"PLAIN", UCHAR_LEN("testuser\0"), "testuser", NULL, FALSE, FALSE, FALSE},
 
@@ -265,9 +265,9 @@ static void test_mechs(void)
                {"PLAIN", UCHAR_LEN("\0fa\0il\0ing\0withthis"), NULL, NULL, FALSE, FALSE, FALSE},
                {"PLAIN", UCHAR_LEN("failingwiththis"), NULL, NULL, FALSE, FALSE, FALSE},
                {"PLAIN", UCHAR_LEN("failing\0withthis"), NULL, NULL, FALSE, FALSE, FALSE},
-               {"OTP", UCHAR_LEN("someb\0ody\0testuser"), NULL, "invalid input", FALSE, FALSE, FALSE},
+               {"OTP", UCHAR_LEN("someb\0ody\0testuser"), NULL, NULL, FALSE, FALSE, FALSE},
                /* phase 2 */
-               {"OTP", UCHAR_LEN("someb\0ody\0testuser"), "testuser", "unsupported response type", FALSE, TRUE, FALSE},
+               {"OTP", UCHAR_LEN("someb\0ody\0testuser"), "testuser", NULL, FALSE, TRUE, FALSE},
                {"SCRAM-SHA-1", UCHAR_LEN("c=biws,r=fyko+d2lbbFgONRv9qkxdawL3rfcNHYJY1ZVvWVs7j,p=v0X8v3Bz2T0CJGbJQyF0X+HI4Ts="), NULL, NULL, FALSE, FALSE, FALSE},
                {"SCRAM-SHA-1", UCHAR_LEN("iws0X8v3Bz2T0CJGbJQyF0X+HI4Ts=,,,,"), NULL, NULL, FALSE, FALSE, FALSE},
                {"SCRAM-SHA-1", UCHAR_LEN("n,a=masteruser,,"), NULL, NULL, FALSE, FALSE, FALSE},