coverity: #1425819

Resource leak

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

diff --git a/src/lxc/tools/lxc_ls.c b/src/lxc/tools/lxc_ls.c
index 7f170e8c302663cacfafddd54e4676404a628e16..5c86d5d07b2a07a447180349327673934196a02b 100644 (file)
--- a/src/lxc/tools/lxc_ls.c
+++ b/src/lxc/tools/lxc_ls.c
@@ -803,10 +803,11 @@ static void ls_print_fancy_format(struct ls *l, struct lengths *lht,
        /* Check for invalid keys. */
        for (s = tmp; s && *s; s++) {
                if (strcasecmp(*s, "NAME") && strcasecmp(*s, "STATE") &&
-                               strcasecmp(*s, "PID") && strcasecmp(*s, "RAM") &&
-                               strcasecmp(*s, "SWAP") && strcasecmp(*s, "AUTOSTART") &&
-                               strcasecmp(*s, "GROUPS") && strcasecmp(*s, "INTERFACE") &&
-                               strcasecmp(*s, "IPV4") && strcasecmp(*s, "IPV6")) {
+                   strcasecmp(*s, "PID") && strcasecmp(*s, "RAM") &&
+                   strcasecmp(*s, "SWAP") && strcasecmp(*s, "AUTOSTART") &&
+                   strcasecmp(*s, "GROUPS") && strcasecmp(*s, "INTERFACE") &&
+                   strcasecmp(*s, "IPV4") && strcasecmp(*s, "IPV6")) {
+                       lxc_free_array((void **)tmp, free);
                        fprintf(stderr, "Invalid key: %s\n", *s);
                        return;
                }
@@ -879,6 +880,8 @@ static void ls_print_fancy_format(struct ls *l, struct lengths *lht,
                }
                printf("\n");
        }
+
+       lxc_free_array((void **)tmp, free);
 }
 
 static void ls_print_table(struct ls *l, struct lengths *lht,