net: dsa: realtek: Fix LED group port bit for non-zero LED group

The rtl8366rb_led_group_port_mask() function always returns LED port
bit in LED group 0; the switch statement returns the same thing in all
non-default cases.

This means that the driver does not currently support configuring LEDs
in non-zero LED groups.

Fix this.

Fixes: 32d617005475a71e ("net: dsa: realtek: add LED drivers for rtl8366rb")
Signed-off-by: Marek Behún <kabel@kernel.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20260311111237.29002-1-kabel@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/dsa/realtek/rtl8366rb-leds.c b/drivers/net/dsa/realtek/rtl8366rb-leds.c
index 99c890681ae6079c67f62130bb5a0f673864def3..509ffd3f8db5cbcb2557f7c2e5d8326a3374fe1e 100644 (file)
--- a/drivers/net/dsa/realtek/rtl8366rb-leds.c
+++ b/drivers/net/dsa/realtek/rtl8366rb-leds.c
@@ -12,11 +12,11 @@ static inline u32 rtl8366rb_led_group_port_mask(u8 led_group, u8 port)
        case 0:
                return FIELD_PREP(RTL8366RB_LED_0_X_CTRL_MASK, BIT(port));
        case 1:
-               return FIELD_PREP(RTL8366RB_LED_0_X_CTRL_MASK, BIT(port));
+               return FIELD_PREP(RTL8366RB_LED_X_1_CTRL_MASK, BIT(port));
        case 2:
-               return FIELD_PREP(RTL8366RB_LED_0_X_CTRL_MASK, BIT(port));
+               return FIELD_PREP(RTL8366RB_LED_2_X_CTRL_MASK, BIT(port));
        case 3:
-               return FIELD_PREP(RTL8366RB_LED_0_X_CTRL_MASK, BIT(port));
+               return FIELD_PREP(RTL8366RB_LED_X_3_CTRL_MASK, BIT(port));
        default:
                return 0;
        }