]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
hwmon: (dell-smm) Remove Dell Precision 490 custom config data
authorArmin Wolf <W_Armin@gmx.de>
Wed, 17 Sep 2025 18:10:33 +0000 (20:10 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 Nov 2025 20:34:07 +0000 (15:34 -0500)
[ Upstream commit ddb61e737f04e3c6c8299c1e00bf17a42a7f05cf ]

It turns out the second fan on the Dell Precision 490 does not
really support I8K_FAN_TURBO. Setting the fan state to 3 enables
automatic fan control, just like on the other two fans.
The reason why this was misinterpreted as turbo mode was that
the second fan normally spins faster in automatic mode than
in the previous fan states. Yet when in state 3, the fan speed
reacts to heat exposure, exposing the automatic mode setting.

Link: https://github.com/lm-sensors/lm-sensors/pull/383
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
Link: https://lore.kernel.org/r/20250917181036.10972-2-W_Armin@gmx.de
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/hwmon/dell-smm-hwmon.c

index b043fbd15c9da8add90838e2d260370bac7500b4..f73f4619374827da07db796481cef8966a2887da 100644 (file)
@@ -1324,7 +1324,6 @@ struct i8k_config_data {
 
 enum i8k_configs {
        DELL_LATITUDE_D520,
-       DELL_PRECISION_490,
        DELL_STUDIO,
        DELL_XPS,
 };
@@ -1334,10 +1333,6 @@ static const struct i8k_config_data i8k_config_data[] __initconst = {
                .fan_mult = 1,
                .fan_max = I8K_FAN_TURBO,
        },
-       [DELL_PRECISION_490] = {
-               .fan_mult = 1,
-               .fan_max = I8K_FAN_TURBO,
-       },
        [DELL_STUDIO] = {
                .fan_mult = 1,
                .fan_max = I8K_FAN_HIGH,
@@ -1357,15 +1352,6 @@ static const struct dmi_system_id i8k_config_dmi_table[] __initconst = {
                },
                .driver_data = (void *)&i8k_config_data[DELL_LATITUDE_D520],
        },
-       {
-               .ident = "Dell Precision 490",
-               .matches = {
-                       DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
-                       DMI_MATCH(DMI_PRODUCT_NAME,
-                                 "Precision WorkStation 490"),
-               },
-               .driver_data = (void *)&i8k_config_data[DELL_PRECISION_490],
-       },
        {
                .ident = "Dell Studio",
                .matches = {