vircgroup: extract virCgroupV1GetMemoryUsage

Reviewed-by: Fabiano Fidêncio <fidencio@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>

diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c
index 55a17acae39677d57c7debf94529b9723acb8fc2..520904308fd331cfac188a0d1303a93906cc3bcb 100644 (file)
--- a/src/util/vircgroup.c
+++ b/src/util/vircgroup.c
@@ -1633,14 +1633,7 @@ virCgroupGetMemoryStat(virCgroupPtr group,
 int
 virCgroupGetMemoryUsage(virCgroupPtr group, unsigned long *kb)
 {
-    long long unsigned int usage_in_bytes;
-    int ret;
-    ret = virCgroupGetValueU64(group,
-                               VIR_CGROUP_CONTROLLER_MEMORY,
-                               "memory.usage_in_bytes", &usage_in_bytes);
-    if (ret == 0)
-        *kb = (unsigned long) usage_in_bytes >> 10;
-    return ret;
+    VIR_CGROUP_BACKEND_CALL(group, getMemoryUsage, -1, kb);
 }
 
 

diff --git a/src/util/vircgroupbackend.h b/src/util/vircgroupbackend.h
index 99754a63102894abf0a174ba6fd6e28c655764ad..8bdfc5c835b0d3af3959b77366816681fcc7189b 100644 (file)
--- a/src/util/vircgroupbackend.h
+++ b/src/util/vircgroupbackend.h
@@ -223,6 +223,10 @@ typedef int
                             unsigned long long *inactiveFile,
                             unsigned long long *unevictable);
 
+typedef int
+(*virCgroupGetMemoryUsageCB)(virCgroupPtr group,
+                             unsigned long *kb);
+
 struct _virCgroupBackend {
     virCgroupBackendType type;
 
@@ -264,6 +268,7 @@ struct _virCgroupBackend {
 
     virCgroupSetMemoryCB setMemory;
     virCgroupGetMemoryStatCB getMemoryStat;
+    virCgroupGetMemoryUsageCB getMemoryUsage;
 };
 typedef struct _virCgroupBackend virCgroupBackend;
 typedef virCgroupBackend *virCgroupBackendPtr;

diff --git a/src/util/vircgroupv1.c b/src/util/vircgroupv1.c
index 9ecdd253cb4c9290a87153dce7d5dc9a9d7c8cea..0cd70cc5122e14d30da4169d03aff7845e4d3f29 100644 (file)
--- a/src/util/vircgroupv1.c
+++ b/src/util/vircgroupv1.c
@@ -1478,6 +1478,21 @@ virCgroupV1GetMemoryStat(virCgroupPtr group,
 }
 
 
+static int
+virCgroupV1GetMemoryUsage(virCgroupPtr group,
+                          unsigned long *kb)
+{
+    long long unsigned int usage_in_bytes;
+    int ret;
+    ret = virCgroupGetValueU64(group,
+                               VIR_CGROUP_CONTROLLER_MEMORY,
+                               "memory.usage_in_bytes", &usage_in_bytes);
+    if (ret == 0)
+        *kb = (unsigned long) usage_in_bytes >> 10;
+    return ret;
+}
+
+
 virCgroupBackend virCgroupV1Backend = {
     .type = VIR_CGROUP_BACKEND_TYPE_V1,
 
@@ -1517,6 +1532,7 @@ virCgroupBackend virCgroupV1Backend = {
 
     .setMemory = virCgroupV1SetMemory,
     .getMemoryStat = virCgroupV1GetMemoryStat,
+    .getMemoryUsage = virCgroupV1GetMemoryUsage,
 };