Bug 313941: sanitycheck should quote bad values so empty values are apparent

Patch by Matt McHenry <mmchenry@carnegielearning.com>
r=wurblzap, a=justdave

diff --git a/sanitycheck.cgi b/sanitycheck.cgi
index 0ae58591c58c8635036ce2ec3e71b6aff37b2a54..317464749b99bcc705b99e6f934b7430a2987ad2 100755 (executable)
--- a/sanitycheck.cgi
+++ b/sanitycheck.cgi
@@ -302,7 +302,7 @@ sub CrossCheck {
         while (MoreSQLData()) {
             my ($value, $key) = FetchSQLData();
             if (!$exceptions{$value}) {
-                my $alert = "Bad value $value found in $refertable.$referfield";
+                my $alert = "Bad value "$value" found in $refertable.$referfield";
                 if ($keyname) {
                     if ($keyname eq 'bug_id') {
                         $alert .= ' (bug ' . BugLink($key) . ')';
@@ -463,7 +463,7 @@ sub DoubleCrossCheck {
         while (MoreSQLData()) {
             my ($value1, $value2, $key) = FetchSQLData();
  
-            my $alert = "Bad values $value1, $value2 found in " .
+            my $alert = "Bad values "$value1", "$value2" found in " .
                 "$refertable.$referfield1 / $refertable.$referfield2";
             if ($keyname) {
                 if ($keyname eq 'bug_id') {