]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: Fix typo in qemuDomainModifyDeviceFlags
authorMichal Privoznik <mprivozn@redhat.com>
Thu, 2 Aug 2012 14:25:41 +0000 (16:25 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Thu, 2 Aug 2012 14:43:57 +0000 (16:43 +0200)
One of our latest commits fbe87126 introduced this nasty typo:
func(vmdef, ...); where func() dereference vmdef->ncontrollers,
and vmdef was initialized to NULL. This leaves us with unconditional
immediate segfault. It should be vm->def instead.

src/qemu/qemu_driver.c

index b3f946c911f4437ceb7f950e4abc37ca57e71c78..270e4dd93aae8bb9196b6f54cce48d2af95abb40 100644 (file)
@@ -5833,7 +5833,7 @@ qemuDomainModifyDeviceFlags(virDomainPtr dom, const char *xml,
     }
 
     if (flags & VIR_DOMAIN_AFFECT_CONFIG) {
-        if (virDomainDefCompatibleDevice(vmdef, dev) < 0)
+        if (virDomainDefCompatibleDevice(vm->def, dev) < 0)
             goto endjob;
 
         /* Make a copy for updated domain. */