device: accept any io.Reader in device.IpcSetOperation

Any io.Reader will do, and there are no performance concerns here.
This is technically backwards incompatible,
but it is very unlikely to break any existing code.
It is compatible with the existing uses in wireguard-{windows,android,apple}
and also will allow us to slightly simplify it if desired.

Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>

diff --git a/device/uapi.go b/device/uapi.go
index 9f9c9bd3803b80f35a323d7c04c33870958f1599..c0e522b16abdedec2bf58ce5c8fc38e1acc064d1 100644 (file)
--- a/device/uapi.go
+++ b/device/uapi.go
@@ -107,8 +107,8 @@ func (device *Device) IpcGetOperation(socket *bufio.Writer) error {
        return nil
 }
 
-func (device *Device) IpcSetOperation(socket *bufio.Reader) error {
-       scanner := bufio.NewScanner(socket)
+func (device *Device) IpcSetOperation(r io.Reader) error {
+       scanner := bufio.NewScanner(r)
        logError := device.log.Error
        logDebug := device.log.Debug