mailbox: mailbox-test: Fix debugfs_create_dir error checking

[ Upstream commit 3acf1028f5003731977f750a7070f3321a9cb740 ]

The debugfs_create_dir() function returns ERR_PTR() on error, not NULL.
The current null-check fails to catch errors.

Use IS_ERR() to correctly check for errors.

Fixes: 8ea4484d0c2b ("mailbox: Add generic mechanism for testing Mailbox Controllers")
Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
Signed-off-by: Jassi Brar <jassisinghbrar@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/mailbox/mailbox-test.c b/drivers/mailbox/mailbox-test.c
index abcee58e851c2dd68e66e79cbc78e042a61e155f..29c04157b5e88feb613f17ebfc1b81f5d29458d3 100644 (file)
--- a/drivers/mailbox/mailbox-test.c
+++ b/drivers/mailbox/mailbox-test.c
@@ -267,7 +267,7 @@ static int mbox_test_add_debugfs(struct platform_device *pdev,
                return 0;
 
        tdev->root_debugfs_dir = debugfs_create_dir(dev_name(&pdev->dev), NULL);
-       if (!tdev->root_debugfs_dir) {
+       if (IS_ERR(tdev->root_debugfs_dir)) {
                dev_err(&pdev->dev, "Failed to create Mailbox debugfs\n");
                return -EINVAL;
        }