]> git.ipfire.org Git - thirdparty/hostap.git/commitdiff
dbus: Add explicit break statements to switch-default
authorJouni Malinen <j@w1.fi>
Thu, 12 Jun 2014 17:08:00 +0000 (20:08 +0300)
committerJouni Malinen <j@w1.fi>
Thu, 12 Jun 2014 21:27:15 +0000 (00:27 +0300)
There were couple of missing breaks in switch-default (before/after).
While these did not have any noticeable issues due to falling over to
the next step that just exited from the switch statement, it is cleaner
and more robust to have each case use an explicit break.

Signed-off-by: Jouni Malinen <j@w1.fi>
wpa_supplicant/dbus/dbus_dict_helpers.c
wpa_supplicant/dbus/dbus_new_handlers_p2p.c

index 80a1178e2ddc1f3e34a1bc828bdd4007aae06493..949ce7c91a67696c4529ab4be0f654045e4c13cc 100644 (file)
@@ -934,6 +934,7 @@ static dbus_bool_t _wpa_dbus_dict_entry_get_array(
                break;
        case DBUS_TYPE_ARRAY:
                success = _wpa_dbus_dict_entry_get_binarray(&iter_array, entry);
+               break;
        default:
                break;
        }
index 8be82888c4765e3c9c811007ef199027ba787822..af319e6f526e857eb276756bba761532df90d588 100644 (file)
@@ -1143,6 +1143,7 @@ dbus_bool_t wpas_dbus_getter_p2p_role(DBusMessageIter *iter, DBusError *error,
                break;
        default:
                str = "device";
+               break;
        }
 
        return wpas_dbus_simple_property_getter(iter, DBUS_TYPE_STRING, &str,