]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
libdns: add missing checks for return values in dnstap unit test
authorOndřej Surý <ondrej@sury.org>
Thu, 31 Oct 2019 11:50:58 +0000 (06:50 -0500)
committerOndřej Surý <ondrej@sury.org>
Mon, 4 Nov 2019 15:15:22 +0000 (16:15 +0100)
Related scan-build report:

dnstap_test.c:169:2: warning: Value stored to 'result' is never read
        result = dns_test_makeview("test", &view);
        ^        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
dnstap_test.c:193:2: warning: Value stored to 'result' is never read
        result = dns_compress_init(&cctx, -1, dt_mctx);
        ^        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 warnings generated.

lib/dns/tests/dnstap_test.c

index da71a6c546739280e06fca99e084f225482c2233..963f290e71ff9f06f3a6419fb551f1d0e07882e9 100644 (file)
@@ -167,6 +167,7 @@ send_test(void **state) {
        cleanup();
 
        result = dns_test_makeview("test", &view);
+       assert_int_equal(result, ISC_R_SUCCESS);
 
        fopt = fstrm_iothr_options_init();
        assert_non_null(fopt);
@@ -191,6 +192,7 @@ send_test(void **state) {
        memset(&zr, 0, sizeof(zr));
        isc_buffer_init(&zb, zone, sizeof(zone));
        result = dns_compress_init(&cctx, -1, dt_mctx);
+       assert_int_equal(result, ISC_R_SUCCESS);
        dns_compress_setmethods(&cctx, DNS_COMPRESS_NONE);
        result = dns_name_towire(zname, &cctx, &zb);
        assert_int_equal(result, ISC_R_SUCCESS);