e2image: fix resource leak when running e2image -n

Addresses-Coverity-ID: #1147783

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>

diff --git a/misc/e2image.c b/misc/e2image.c
index ab6a4fa666c748acf9b683d711769a0bb7016b73..253fad1d011cb50b14fd399ae00b54ff81ec6f90 100644 (file)
--- a/misc/e2image.c
+++ b/misc/e2image.c
@@ -174,7 +174,7 @@ static void generic_write(int fd, void *buf, int blocksize, blk64_t block)
                printf(_("Writing block %llu\n"), (unsigned long long) block);
                if (fd != 1)
                        seek_relative(fd, blocksize);
-               return;
+               goto free_and_return;
        }
        count = write(fd, buf, blocksize);
        if (count != blocksize) {
@@ -191,6 +191,7 @@ static void generic_write(int fd, void *buf, int blocksize, blk64_t block)
 
                exit(1);
        }
+free_and_return:
        if (free_buf)
                ext2fs_free_mem(&buf);
 }