]> git.ipfire.org Git - thirdparty/libarchive.git/commitdiff
Add TODO comment for future error propagation 2897/head
authorelhananhaenel <elhanan.haenel@mail.huji.ac.il>
Sun, 8 Mar 2026 13:33:50 +0000 (15:33 +0200)
committerelhananhaenel <elhanan.haenel@mail.huji.ac.il>
Sun, 8 Mar 2026 13:33:50 +0000 (15:33 +0200)
libarchive/archive_read_support_format_iso9660.c

index 64016d488230c0e198066a8a0306a4c71922109d..eb37d75ee3e304129b92a9bf9bc261228e5d49e6 100644 (file)
@@ -2760,7 +2760,10 @@ parse_rockridge_ZF1(struct file_info *file, const unsigned char *data,
         file->pz = 1;
         file->pz_log2_bs = data[3];
         if (file->pz_log2_bs < 15 || file->pz_log2_bs > 17) {
-            /* Invalid block size exponent; disable zisofs. */
+            /* TODO: Return an error here instead of silently
+             * disabling zisofs. That requires propagating an
+             * error return through parse_rockridge() and its
+             * callers. */
             file->pz = 0;
             return;
         }