device: fix error shadowing before log print

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>

diff --git a/device/receive.go b/device/receive.go
index aeaae51d2f5c12364321ce9207c750aa310494d4..e9cf2bc594b4ceb45849f29fd27008b17a81481e 100644 (file)
--- a/device/receive.go
+++ b/device/receive.go
@@ -633,14 +633,14 @@ func (peer *Peer) RoutineSequentialReceiver() {
 
                offset := MessageTransportOffsetContent
                _, err := device.tun.device.Write(elem.buffer[:offset+len(elem.packet)], offset)
+               if err != nil && !device.isClosed.Get() {
+                       logError.Println("Failed to write packet to TUN device:", err)
+               }
                if len(peer.queue.inbound) == 0 {
-                       err = device.tun.device.Flush()
+                       err := device.tun.device.Flush()
                        if err != nil {
                                peer.device.log.Error.Printf("Unable to flush packets: %v", err)
                        }
                }
-               if err != nil && !device.isClosed.Get() {
-                       logError.Println("Failed to write packet to TUN device:", err)
-               }
        }
 }