modules/renumber: don't accidentally zero-out .state

It was possible for some failures to disappear that way.

diff --git a/NEWS b/NEWS
index 46f5db954d222cae1b64f70bad3d423dfaddcfe2..7e5cc940651a21189effbf85302287f404e45646 100644 (file)
--- a/NEWS
+++ b/NEWS
@@ -15,11 +15,13 @@ Improvements
 - lua: remove dependency on lua-socket and lua-sec, used lua-http and cqueues (#512, #521, !894)
 - net.listen(): allow binding to non-local address with freebind option (!898)
 - cache: pre-allocate the file to avoid SIGBUS later (not macOS; !917, #525)
+- lua: be stricter around nonsense returned from modules (!901)
 
 Bugfixes
 --------
 - correctly use EDNS(0) padding in failed answers (!921)
 - policy and daf modules: fix reroute rules (!901)
+- renumber module: don't accidentally zero-out request's .state (!901)
 
 
 Knot Resolver 4.3.0 (2019-12-04)

diff --git a/modules/renumber/renumber.lua b/modules/renumber/renumber.lua
index 3e934dfce3fb60fe60cc2ead1f38f82608882e29..8512093ab0af435fed03f83af0772117c9c169c1 100644 (file)
--- a/modules/renumber/renumber.lua
+++ b/modules/renumber/renumber.lua
@@ -82,7 +82,7 @@ local function rule(prefixes)
                        end
                end
                -- If not rewritten, chain action
-               if not changed then return end
+               if not changed then return state end
                -- Replace section if renumbering
                local qname = pkt:qname()
                local qclass = pkt:qclass()