lib-http: client: Cleaned up initialization of client settings.

There were checks for the client context not being NULL, which makes no sense anymore, since a private context is always created when none is provided.
Problem reported by Coverity.

diff --git a/src/lib-http/http-client.c b/src/lib-http/http-client.c
index 561b7015c196e956b0cfed782f1b28f7353e298d..7bf58b317fff780ff0b85f23f6e0944796f20f73 100644 (file)
--- a/src/lib-http/http-client.c
+++ b/src/lib-http/http-client.c
@@ -135,9 +135,8 @@ http_client_init_shared(struct http_client_context *cctx,
        }
 
        /* merge provided settings with context defaults */
-       i_assert(cctx != NULL || set != NULL);
        client->set = cctx->set;
-       if (cctx != NULL && set != NULL) {
+       if (set != NULL) {
                if (set->user_agent != NULL && *set->user_agent != '\0')
                        client->set.user_agent = p_strdup_empty(pool, set->user_agent);
                if (set->rawlog_dir != NULL && *set->rawlog_dir != '\0')