2005-02-09 Jakub Jelinek <jakub@redhat.com>

	[BZ #710]
	* stdlib/random_r.c (__initstate_r): Save old state.
	* stdlib/Makefile (tests): Add tst-random2.
	* stdlib/tst-random2.c: New test.
	Reported by Peter Bergner <bergner@vnet.ibm.com>.

diff --git a/stdlib/Makefile b/stdlib/Makefile
index cdf5a91bd0e7a167508ac2e2716db4c6cb1b18ed..24db960044b65325b48837986e7d5aec319ff04b 100644 (file)
--- a/stdlib/Makefile
+++ b/stdlib/Makefile
@@ -61,9 +61,9 @@ distribute    := exit.h grouping.h abort-instr.h isomac.c tst-fmtmsg.sh   \
 test-srcs      := tst-fmtmsg
 tests          := tst-strtol tst-strtod testmb testrand testsort testdiv   \
                   test-canon test-canon2 tst-strtoll tst-environ           \
-                  tst-xpg-basename tst-random tst-bsearch tst-limits       \
-                  tst-rand48 bug-strtod tst-setcontext test-a64l tst-qsort \
-                  tst-system testmb2
+                  tst-xpg-basename tst-random tst-random2 tst-bsearch      \
+                  tst-limits tst-rand48 bug-strtod tst-setcontext          \
+                  test-a64l tst-qsort tst-system testmb2
 
 include ../Makeconfig
 

diff --git a/stdlib/random_r.c b/stdlib/random_r.c
index 09677e6077e3e51737a37660a5051971da6a38ca..e955ea576a5e1ed5606358a4dd2771bd37c78d26 100644 (file)
--- a/stdlib/random_r.c
+++ b/stdlib/random_r.c
@@ -240,10 +240,19 @@ __initstate_r (seed, arg_state, n, buf)
   int degree;
   int separation;
   int32_t *state;
+  int old_type;
+  int32_t *old_state;
 
   if (buf == NULL)
     goto fail;
 
+  old_type = buf->rand_type;
+  old_state = buf->state;
+  if (old_type == TYPE_0)
+    old_state[-1] = TYPE_0;
+  else
+    old_state[-1] = (MAX_TYPES * (buf->rptr - old_state)) + old_type;
+
   if (n >= BREAK_3)
     type = n < BREAK_4 ? TYPE_3 : TYPE_4;
   else if (n < BREAK_1)

diff --git a/stdlib/tst-random2.c b/stdlib/tst-random2.c
new file mode 100644 (file)
index 0000000..aa1b89d
--- /dev/null
+++ b/stdlib/tst-random2.c
@@ -0,0 +1,59 @@
+/* Test initstate saving the old state.
+   Copyright (C) 2005 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+   Contributed by Jakub Jelinek <jakub@redhat.com>, 2005.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, write to the Free
+   Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
+   02111-1307 USA.  */
+
+#include <stdio.h>
+#include <stdlib.h>
+
+int
+main (void)
+{
+  int pass;
+  int ret = 0;
+  long int r[2];
+
+  for (pass = 0; pass < 2; pass++)
+    {
+      srandom (0x12344321);
+
+      int j;
+      for (j = 0; j < 3; ++j)
+       random ();
+      if (pass == 1)
+       {
+         char state[128];
+         char *ostate = initstate (0x34562101, state, 128);
+         if (setstate (ostate) != state)
+           {
+             puts ("setstate (ostate) != state");
+             ret = 1;
+           }
+       }
+
+      random ();
+      r[pass] = random ();
+    }
+
+  if (r[0] != r[1])
+    {
+      printf ("%ld != %ld\n", r[0], r[1]);
+      ret = 1;
+    }
+  return ret;
+}