coverity: #1425850

Insecure temporary file

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

diff --git a/src/lxc/tools/lxc_copy.c b/src/lxc/tools/lxc_copy.c
index 58f3b01dd061ca96129aed2e2197134bc6d73053..9c2600acd955fd8989f7f2d55d44af10e22cab8c 100644 (file)
--- a/src/lxc/tools/lxc_copy.c
+++ b/src/lxc/tools/lxc_copy.c
@@ -744,6 +744,7 @@ static char *mount_tmpfs(const char *oldname, const char *newname,
 {
        int ret, fd;
        size_t len;
+       mode_t msk;
        char *premount = NULL;
        FILE *fp = NULL;
 
@@ -773,7 +774,9 @@ static char *mount_tmpfs(const char *oldname, const char *newname,
        if (ret < 0 || (size_t)ret >= len)
                goto err_free;
 
+       msk = umask(0022);
        fd = mkstemp(premount);
+       umask(msk);
        if (fd < 0)
                goto err_free;