]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
virDomainDiskDef: Change type of discard to virDomainDiskDiscard
authorTim Wiederhake <twiederh@redhat.com>
Thu, 22 Apr 2021 10:32:52 +0000 (12:32 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Thu, 22 Apr 2021 13:30:56 +0000 (15:30 +0200)
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/conf/domain_conf.c
src/conf/domain_conf.h

index 72664bd72b310352a8b5bf4b99c39ddaee995324..9a4252099eba0800941abd7c9d2e277248442c61 100644 (file)
@@ -9046,11 +9046,15 @@ virDomainDiskDefDriverParseXML(virDomainDiskDef *def,
     }
     VIR_FREE(tmp);
 
-    if ((tmp = virXMLPropString(cur, "discard")) &&
-        (def->discard = virDomainDiskDiscardTypeFromString(tmp)) <= 0) {
-        virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
-                       _("unknown disk discard mode '%s'"), tmp);
-        return -1;
+    if ((tmp = virXMLPropString(cur, "discard"))) {
+        int discard;
+
+        if ((discard = virDomainDiskDiscardTypeFromString(tmp)) <= 0) {
+            virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
+                           _("unknown disk discard mode '%s'"), tmp);
+            return -1;
+        }
+        def->discard = discard;
     }
     VIR_FREE(tmp);
 
index 3402b3f85a4e550722849c222e896abb2ad97853..eb4991a312719a2fd2874659d360e8f3cff5c7fa 100644 (file)
@@ -579,7 +579,7 @@ struct _virDomainDiskDef {
     virDomainDeviceInfo info;
     virTristateBool rawio;
     virDomainDeviceSGIO sgio;
-    int discard; /* enum virDomainDiskDiscard */
+    virDomainDiskDiscard discard;
     unsigned int iothread; /* unused = 0, > 0 specific thread # */
     int detect_zeroes; /* enum virDomainDiskDetectZeroes */
     char *domain_name; /* backend domain name */