]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commitdiff
Remove non-working Connection.default_schema_name() method
authorBenjamin Dopplinger <b.dopplinger@gmail.com>
Thu, 10 Nov 2016 16:15:37 +0000 (11:15 -0500)
committerMike Bayer <mike_mp@zzzcomputing.com>
Thu, 10 Nov 2016 16:19:09 +0000 (11:19 -0500)
The method `engine.base.Connection.default_schema_name` is broken since
4b532e2 (this was when `engine.dialect.get_default_schema_name` was
replaced with `engine.dialect.default_schema_name`).  The method is
unused and also is not functional for end-user use, so remove it
for now.

Change-Id: I6ffbd9ce1b9b54ff6df63ed45d7d33591f183933
Pull-request: https://github.com/zzzeek/sqlalchemy/pull/321

doc/build/changelog/changelog_11.rst
lib/sqlalchemy/engine/base.py

index 4c8bdc7d96ba58f8c63215341abdba3c73e29e66..09cd9c4c43ab1d60ff81e42f5bac13d07c9388e9 100644 (file)
 .. changelog::
     :version: 1.1.4
 
+    .. change::
+        :tags: bug, engine
+
+        Removed long-broken "default_schema_name()" method from
+        :class:`.Connection`.  This method was left over from a very old
+        version and was non-working (e.g. would raise).  Pull request
+        courtesy Benjamin Dopplinger.
+
     .. change::
         :tags: bug, sqlite
 
index 1d23c66b3c25a53d6e54b156191a2e0ae1202479..838568605600e2dfb75403ac7e634e2194f51213 100644 (file)
@@ -1458,9 +1458,6 @@ class Connection(Connectable):
         else:
             util.reraise(*exc_info)
 
-    def default_schema_name(self):
-        return self.engine.dialect.get_default_schema_name(self)
-
     def transaction(self, callable_, *args, **kwargs):
         """Execute the given function within a transaction boundary.