]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
clk: tegra: fix error return case for recalc_rate
authorTimo Alho <talho@nvidia.com>
Tue, 12 Sep 2023 11:29:50 +0000 (14:29 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 10 Oct 2023 19:43:39 +0000 (21:43 +0200)
[ Upstream commit a47b44fbb13f5e7a981b4515dcddc93a321ae89c ]

tegra-bpmp clocks driver makes implicit conversion of signed error
code to unsigned value in recalc_rate operation. The behavior for
recalc_rate, according to it's specification, should be that "If the
driver cannot figure out a rate for this clock, it must return 0."

Fixes: ca6f2796eef7 ("clk: tegra: Add BPMP clock driver")
Signed-off-by: Timo Alho <talho@nvidia.com>
Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
Link: https://lore.kernel.org/r/20230912112951.2330497-1-cyndis@kapsi.fi
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/clk/tegra/clk-bpmp.c

index 6c933b0e29a3bfb384a9fb24c369d0ff1ef7fbd4..fcb7c599583b3a7f94131f1002494ca959c4926d 100644 (file)
@@ -154,7 +154,7 @@ static unsigned long tegra_bpmp_clk_recalc_rate(struct clk_hw *hw,
 
        err = tegra_bpmp_clk_transfer(clk->bpmp, &msg);
        if (err < 0)
-               return err;
+               return 0;
 
        return response.rate;
 }