]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
driver core: Put device attribute @wakeup_last_time_ms and its show() together
authorZijun Hu <quic_zijuhu@quicinc.com>
Mon, 28 Oct 2024 12:11:11 +0000 (20:11 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 4 Nov 2024 00:59:18 +0000 (01:59 +0100)
Move location of dpm_sysfs_wakeup_change_owner() a bit to

- Put device attribute @wakeup_last_time_ms and its show() together.
- Put two different instances of dpm_sysfs_wakeup_change_owner() together.

That will make better code layout.

Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
Link: https://lore.kernel.org/r/20241028-fix_power_sysfs-v1-1-7b2fbeb14d47@quicinc.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/power/sysfs.c

index a1474fb67db9b2f09812b293127730efc6655243..f8163b559bf992718f341a64948471c060843320 100644 (file)
@@ -509,14 +509,6 @@ static ssize_t wakeup_last_time_ms_show(struct device *dev,
        return sysfs_emit(buf, "%lld\n", msec);
 }
 
-static inline int dpm_sysfs_wakeup_change_owner(struct device *dev, kuid_t kuid,
-                                               kgid_t kgid)
-{
-       if (dev->power.wakeup && dev->power.wakeup->dev)
-               return device_change_owner(dev->power.wakeup->dev, kuid, kgid);
-       return 0;
-}
-
 static DEVICE_ATTR_RO(wakeup_last_time_ms);
 
 #ifdef CONFIG_PM_AUTOSLEEP
@@ -541,6 +533,15 @@ static ssize_t wakeup_prevent_sleep_time_ms_show(struct device *dev,
 
 static DEVICE_ATTR_RO(wakeup_prevent_sleep_time_ms);
 #endif /* CONFIG_PM_AUTOSLEEP */
+
+static inline int dpm_sysfs_wakeup_change_owner(struct device *dev, kuid_t kuid,
+                                               kgid_t kgid)
+{
+       if (dev->power.wakeup && dev->power.wakeup->dev)
+               return device_change_owner(dev->power.wakeup->dev, kuid, kgid);
+       return 0;
+}
+
 #else /* CONFIG_PM_SLEEP */
 static inline int dpm_sysfs_wakeup_change_owner(struct device *dev, kuid_t kuid,
                                                kgid_t kgid)