]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
arm64: dts: imx8mp-ab2: Correct interrupt flags
authorKrzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Mon, 6 Apr 2026 06:38:13 +0000 (08:38 +0200)
committerFrank Li <Frank.Li@nxp.com>
Tue, 5 May 2026 19:26:48 +0000 (15:26 -0400)
GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.
These are simple defines so they could be used in DTS but they will not
have the same meaning:
1. GPIO_ACTIVE_HIGH = 0 => IRQ_TYPE_NONE
2. GPIO_ACTIVE_LOW  = 1 => IRQ_TYPE_EDGE_RISING

Correct the interrupt flags, assuming the author of the code wanted the
same logical behavior behind the name "ACTIVE_xxx", this is:
ACTIVE_LOW  => IRQ_TYPE_LEVEL_LOW

Fixes: bf68c18150ef ("arm64: dts: imx8mp-ab2: add support for NXP i.MX8MP audio board (version 2)")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Reviewed-by: Shengjiu Wang <shengjiu.wang@nxp.com>
Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
arch/arm64/boot/dts/freescale/imx8mp-ab2.dts

index dbbc0df0e3d1c7161b4210333decd55d70c206f4..443e4fd5b9bfc1c64f9865c190cb64d59df39b82 100644 (file)
                compatible = "nxp,pca9450c";
                reg = <0x25>;
                interrupt-parent = <&gpio1>;
-               interrupts = <3 GPIO_ACTIVE_LOW>;
+               interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
                pinctrl-0 = <&pinctrl_pmic>;
 
                regulators {