]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ipmi: ipmb: Add check devm_kasprintf() returned value
authorCharles Han <hanchunchao@inspur.com>
Thu, 26 Sep 2024 09:44:19 +0000 (17:44 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 Mar 2025 11:49:52 +0000 (12:49 +0100)
[ Upstream commit 2378bd0b264ad3a1f76bd957caf33ee0c7945351 ]

devm_kasprintf() can return a NULL pointer on failure but this
returned value is not checked.

Fixes: 51bd6f291583 ("Add support for IPMB driver")
Signed-off-by: Charles Han <hanchunchao@inspur.com>
Message-ID: <20240926094419.25900-1-hanchunchao@inspur.com>
Signed-off-by: Corey Minyard <corey@minyard.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/char/ipmi/ipmb_dev_int.c

index 49b8f22fdcf03b8883e378d28e07ce13172df854..964bde656f0d3d22b29b966bb26fac9c2d7083a3 100644 (file)
@@ -322,6 +322,9 @@ static int ipmb_probe(struct i2c_client *client,
        ipmb_dev->miscdev.name = devm_kasprintf(&client->dev, GFP_KERNEL,
                                                "%s%d", "ipmb-",
                                                client->adapter->nr);
+       if (!ipmb_dev->miscdev.name)
+               return -ENOMEM;
+
        ipmb_dev->miscdev.fops = &ipmb_fops;
        ipmb_dev->miscdev.parent = &client->dev;
        ret = misc_register(&ipmb_dev->miscdev);