]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/amdgpu: don't attach the tlb fence for SI
authorAlex Deucher <alexander.deucher@amd.com>
Tue, 2 Dec 2025 19:24:03 +0000 (14:24 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 8 Dec 2025 20:24:16 +0000 (15:24 -0500)
SI hardware doesn't support pasids, user mode queues, or
KIQ/MES so there is no need for this.  Doing so results in
a segfault as these callbacks are non-existent for SI.

Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/4744
Fixes: f3854e04b708 ("drm/amdgpu: attach tlb fence to the PTs update")
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
(cherry picked from commit 820b3d376e8a102c6aeab737ec6edebbbb710e04)

drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c

index a67285118c37ba68a97e395fcf389a99d9207128..c362d4dfb5bbb6eb074fb3806c6003b354b98e56 100644 (file)
@@ -1069,7 +1069,9 @@ amdgpu_vm_tlb_flush(struct amdgpu_vm_update_params *params,
        }
 
        /* Prepare a TLB flush fence to be attached to PTs */
-       if (!params->unlocked) {
+       if (!params->unlocked &&
+           /* SI doesn't support pasid or KIQ/MES */
+           params->adev->family > AMDGPU_FAMILY_SI) {
                amdgpu_vm_tlb_fence_create(params->adev, vm, fence);
 
                /* Makes sure no PD/PT is freed before the flush */