]> git.ipfire.org Git - thirdparty/knot-dns.git/commitdiff
zone backup: remove an excessive directory creation
authorDavid Vašek <david.vasek@nic.cz>
Tue, 2 Feb 2021 09:09:13 +0000 (10:09 +0100)
committerDavid Vašek <david.vasek@nic.cz>
Tue, 2 Feb 2021 13:50:12 +0000 (14:50 +0100)
The directory has already been created before as a part of the lockfile preparation.

src/knot/zone/backup.c

index 1903185577d2a4d18efbf462feaff7922c5aa4a2..f1679006ee929efc6f48d6bff9f951ecd1e77d4b 100644 (file)
@@ -84,15 +84,6 @@ int zone_backup_init(bool restore_mode, const char *backup_dir,
 
        pthread_mutex_init(&ctx->readers_mutex, NULL);
 
-       if (!restore_mode) {
-               int ret = mkdir(backup_dir, 0750);
-               if (ret == -1 && errno != EEXIST) {
-                       pthread_mutex_destroy(&ctx->readers_mutex);
-                       free(ctx);
-                       return knot_map_errno();
-               }
-       }
-
        char db_dir[backup_dir_len + 16];
        (void)snprintf(db_dir, sizeof(db_dir), "%s/keys", backup_dir);
        knot_lmdb_init(&ctx->bck_kasp_db, db_dir, kasp_db_size, 0, "keys_db");