]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
ch: Rework virCHProcessConnectMonitor()
authorMichal Privoznik <mprivozn@redhat.com>
Thu, 13 Mar 2025 12:03:02 +0000 (13:03 +0100)
committerMichal Privoznik <mprivozn@redhat.com>
Thu, 13 Mar 2025 14:51:15 +0000 (15:51 +0100)
Firstly, let's switch from explicit virCHDriverGetConfig() +
virObjectUnref() combo to g_autoptr(virCHDriverConfig). This
leaves us with the @monitor variable which is initialized to NULL
only to be then set to the retval of virCHMonitorNew() and
returned instantly. Well, the variable is now useless and can be
dropped.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
src/ch/ch_process.c

index 79f5990cc171364f941e943022e21cf8cf296b43..ee86430e084b2962a749b03bfd4186a21fcd806a 100644 (file)
@@ -53,13 +53,9 @@ virCHProcessConnectMonitor(virCHDriver *driver,
                            virDomainObj *vm,
                            int logfile)
 {
-    virCHMonitor *monitor = NULL;
-    virCHDriverConfig *cfg = virCHDriverGetConfig(driver);
-
-    monitor = virCHMonitorNew(vm, cfg, logfile);
+    g_autoptr(virCHDriverConfig) cfg = virCHDriverGetConfig(driver);
 
-    virObjectUnref(cfg);
-    return monitor;
+    return virCHMonitorNew(vm, cfg, logfile);
 }
 
 static void