]> git.ipfire.org Git - thirdparty/haproxy.git/commitdiff
BUG/MINOR: ssl: ssl_sock_load_issuer_file_into_ckch memory leak
authorEmmanuel Hocdet <manu@gandi.net>
Thu, 16 Jan 2020 13:45:00 +0000 (14:45 +0100)
committerWilliam Lallemand <wlallemand@haproxy.org>
Tue, 21 Jan 2020 09:44:33 +0000 (10:44 +0100)
"set ssl cert <filename.issuer> <payload>" CLI command must free
previous context.

This patch should be backport to 2.1

src/ssl_sock.c

index 7d654bde827aa262a0506d9efd7de4606cf1b3ff..e2c58a50fba6bf902b14183550d9e926d02aefa5 100644 (file)
@@ -3237,8 +3237,11 @@ static int ssl_sock_load_issuer_file_into_ckch(const char *path, char *buf, stru
                          err && *err ? *err : "", path);
                goto end;
        }
-       ret = 0;
+       /* no error, fill ckch with new context, old context must be free */
+       if (ckch->ocsp_issuer)
+               X509_free(ckch->ocsp_issuer);
        ckch->ocsp_issuer = issuer;
+       ret = 0;
 
 end: