]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
nfsd: Mark variable __maybe_unused to avoid W=1 build break
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Thu, 13 Nov 2025 08:31:31 +0000 (09:31 +0100)
committerChuck Lever <chuck.lever@oracle.com>
Mon, 8 Dec 2025 15:56:34 +0000 (10:56 -0500)
Clang is not happy about set but (in some cases) unused variable:

fs/nfsd/export.c:1027:17: error: variable 'inode' set but not used [-Werror,-Wunused-but-set-variable]

since it's used as a parameter to dprintk() which might be configured
a no-op. To avoid uglifying code with the specific ifdeffery just mark
the variable __maybe_unused.

The commit [1], which introduced this behaviour, is quite old and hence
the Fixes tag points to the first of the Git era.

Link: https://git.kernel.org/pub/scm/linux/kernel/git/history/history.git/commit/?id=0431923fb7a1
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Cc: stable@vger.kernel.org
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/export.c

index 9d55512d0cc97fb51dec06db4709cb99ab3ad990..2a1499f2ad196a6033787260881e451146283bdc 100644 (file)
@@ -1024,7 +1024,7 @@ exp_rootfh(struct net *net, struct auth_domain *clp, char *name,
 {
        struct svc_export       *exp;
        struct path             path;
-       struct inode            *inode;
+       struct inode            *inode __maybe_unused;
        struct svc_fh           fh;
        int                     err;
        struct nfsd_net         *nn = net_generic(net, nfsd_net_id);