]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
leds: pca955x: Correct I2C Functionality
authorTin Huynh <tnhuynh@apm.com>
Mon, 22 May 2017 09:19:20 +0000 (16:19 +0700)
committerSasha Levin <alexander.levin@microsoft.com>
Wed, 23 May 2018 01:36:25 +0000 (21:36 -0400)
[ Upstream commit aace34c0bb8ea3c8bdcec865b6a4be4db0a68e33 ]

The driver checks an incorrect flag of functionality of adapter.
When a driver requires i2c_smbus_read_byte_data and
i2c_smbus_write_byte_data, it should check I2C_FUNC_SMBUS_BYTE_DATA
instead I2C_FUNC_I2C.
This patch fixes the problem.

Signed-off-by: Tin Huynh <tnhuynh@apm.com>
Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
drivers/leds/leds-pca955x.c

index c3a08b60535bc31048d1246c1d5ef01dd5c12c6b..760deffa9ad3043b7847671ad8867971115e507b 100644 (file)
@@ -281,7 +281,7 @@ static int pca955x_probe(struct i2c_client *client,
                        "slave address 0x%02x\n",
                        id->name, chip->bits, client->addr);
 
-       if (!i2c_check_functionality(adapter, I2C_FUNC_I2C))
+       if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA))
                return -EIO;
 
        if (pdata) {