]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
SUNRPC: Improve "fragment too large" warning
authorChuck Lever <chuck.lever@oracle.com>
Wed, 8 Oct 2025 15:39:56 +0000 (11:39 -0400)
committerChuck Lever <chuck.lever@oracle.com>
Sun, 16 Nov 2025 23:20:11 +0000 (18:20 -0500)
Including the client IP address that generated the overrun traffic
seems like it would be helpful. The message now reads:

  kernel: svc: nfsd oversized RPC fragment (1064958 octets) from 100.64.0.11:45866

Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
net/sunrpc/svcsock.c

index 7b90abc5cf0ee1520796b2f38fcb977417009830..0cb9c4d457453b26db29f08985b056c3f8d59447 100644 (file)
@@ -1062,9 +1062,10 @@ static ssize_t svc_tcp_read_marker(struct svc_sock *svsk,
        return svc_sock_reclen(svsk);
 
 err_too_large:
-       net_notice_ratelimited("svc: %s %s RPC fragment too large: %d\n",
-                              __func__, svsk->sk_xprt.xpt_server->sv_name,
-                              svc_sock_reclen(svsk));
+       net_notice_ratelimited("svc: %s oversized RPC fragment (%u octets) from %pISpc\n",
+                              svsk->sk_xprt.xpt_server->sv_name,
+                              svc_sock_reclen(svsk),
+                              (struct sockaddr *)&svsk->sk_xprt.xpt_remote);
        svc_xprt_deferred_close(&svsk->sk_xprt);
 err_short:
        return -EAGAIN;