util: annotate non-null arguments for virGDBusCallMethod()

Helps avoid/debug a potential SEGV if conn is NULL, since gio will not
set the "gerror" in that case and we will crash later at:
  virReportError(VIR_ERR_DBUS_SERVICE, "%s", gerror->message);

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>

diff --git a/src/util/virgdbus.h b/src/util/virgdbus.h
index dfe61381121d02cfdc0744d0fac884878b83a9e4..65e7ba7be47f45921717f5e58f71ffada72e2d11 100644 (file)
--- a/src/util/virgdbus.h
+++ b/src/util/virgdbus.h
@@ -54,7 +54,11 @@ virGDBusCallMethod(GDBusConnection *conn,
                    const char *objectPath,
                    const char *ifaceName,
                    const char *method,
-                   GVariant *data);
+                   GVariant *data)
+    ATTRIBUTE_NONNULL(1)
+    ATTRIBUTE_NONNULL(6)
+    ATTRIBUTE_NONNULL(7)
+    ATTRIBUTE_NONNULL(8);
 
 int
 virGDBusCallMethodWithFD(GDBusConnection *conn,
@@ -67,7 +71,12 @@ virGDBusCallMethodWithFD(GDBusConnection *conn,
                          const char *ifaceName,
                          const char *method,
                          GVariant *data,
-                         GUnixFDList *dataFD);
+                         GUnixFDList *dataFD)
+    ATTRIBUTE_NONNULL(1)
+    ATTRIBUTE_NONNULL(7)
+    ATTRIBUTE_NONNULL(8)
+    ATTRIBUTE_NONNULL(9);
+
 
 int
 virGDBusIsServiceEnabled(const char *name);