]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: use g_auto in qemuExtTPMStartEmulator
authorJán Tomko <jtomko@redhat.com>
Fri, 24 Jan 2020 18:32:21 +0000 (19:32 +0100)
committerJán Tomko <jtomko@redhat.com>
Tue, 28 Jan 2020 12:32:27 +0000 (13:32 +0100)
Use the g_auto macros wherever possible to eliminate the cleanup
section.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
src/qemu/qemu_tpm.c

index 262e6c4f078e0207cd7da72968e8c2bb4a93a181..c2132250eb830f583473b6423a4b0f458cdfae7e 100644 (file)
@@ -794,12 +794,12 @@ qemuExtTPMStartEmulator(virQEMUDriverPtr driver,
                         bool incomingMigration)
 {
     int ret = -1;
-    virCommandPtr cmd = NULL;
+    g_autoptr(virCommand) cmd = NULL;
     int exitstatus = 0;
-    char *errbuf = NULL;
-    virQEMUDriverConfigPtr cfg;
+    g_autofree char *errbuf = NULL;
+    g_autoptr(virQEMUDriverConfig) cfg = NULL;
     virDomainTPMDefPtr tpm = vm->def->tpm;
-    char *shortName = virDomainDefGetShortName(vm->def);
+    g_autofree char *shortName = virDomainDefGetShortName(vm->def);
     int cmdret = 0, timeout, rc;
     pid_t pid;
 
@@ -855,12 +855,6 @@ qemuExtTPMStartEmulator(virQEMUDriverPtr driver,
     ret = 0;
 
  cleanup:
-    VIR_FREE(shortName);
-    VIR_FREE(errbuf);
-    virCommandFree(cmd);
-
-    virObjectUnref(cfg);
-
     return ret;
 
  error: