]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: ov08x40: Add missing ov08x40_identify_module() call on stream-start
authorHans de Goede <hdegoede@redhat.com>
Fri, 20 Dec 2024 14:41:28 +0000 (15:41 +0100)
committerHans Verkuil <hverkuil@xs4all.nl>
Sat, 15 Feb 2025 14:22:40 +0000 (15:22 +0100)
The driver might skip the ov08x40_identify_module() on probe() based on
the acpi_dev_state_d0() check done in probe().

If the ov08x40_identify_module() call is skipped on probe() it should
be done on the first stream start. Add the missing call.

Note ov08x40_identify_module() will only do something on its first call,
subsequent calls are no-ops.

Tested-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Fixes: b1a42fde6e07 ("media: ov08x40: Avoid sensor probing in D0 state")
Cc: stable@vger.kernel.org
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
drivers/media/i2c/ov08x40.c

index 39430528f54f9e208c8e3182f0a65d781d357abc..7d00740222c184248b8e54a1da4f8e23bb9c25a6 100644 (file)
@@ -1973,6 +1973,10 @@ static int ov08x40_set_stream(struct v4l2_subdev *sd, int enable)
                if (ret < 0)
                        goto err_unlock;
 
+               ret = ov08x40_identify_module(ov08x);
+               if (ret)
+                       goto err_rpm_put;
+
                /*
                 * Apply default & customized values
                 * and then start streaming.