]> git.ipfire.org Git - thirdparty/plymouth.git/commitdiff
ply-progress-bar: Redraw on percentage update
authorHans de Goede <hdegoede@redhat.com>
Fri, 8 Feb 2019 17:04:01 +0000 (18:04 +0100)
committerHans de Goede <hdegoede@redhat.com>
Sat, 23 Feb 2019 13:56:54 +0000 (14:56 +0100)
All the other plymouth widgets do a (re)draw when one of their
properties get updated. Make ply-progress-bar also do this, this allows
dropping the draw calls directly after the 2 current callers of
ply_progress_bar_set_percent_done.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
src/libply-splash-graphics/ply-progress-bar.c
src/plugins/splash/throbgress/plugin.c

index c0b5f9a0ab80bfd3e61ab2b989bc489349a7b3a5..2ba3bf4048e085aa790d174a57f52397e86c3a03 100644 (file)
@@ -199,6 +199,7 @@ ply_progress_bar_set_percent_done (ply_progress_bar_t *progress_bar,
                                    double              percent_done)
 {
         progress_bar->percent_done = percent_done;
+        ply_progress_bar_draw (progress_bar);
 }
 
 double
index a1c8a90576031c49120f2362ee80e4ba32890d6c..4016d9661a4e7cc0a7254feaaa311eed29b08f89 100644 (file)
@@ -736,7 +736,6 @@ on_boot_progress (ply_boot_splash_plugin_t *plugin,
                 next_node = ply_list_get_next_node (plugin->views, node);
 
                 ply_progress_bar_set_percent_done (view->progress_bar, percent_done);
-                ply_progress_bar_draw (view->progress_bar);
 
                 node = next_node;
         }
@@ -940,7 +939,6 @@ system_update (ply_boot_splash_plugin_t *plugin,
                 view = ply_list_node_get_data (node);
                 next_node = ply_list_get_next_node (plugin->views, node);
                 ply_progress_bar_set_percent_done (view->progress_bar, (double) progress / 100.f);
-                ply_progress_bar_draw (view->progress_bar);
                 node = next_node;
         }
 }