]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
tests/krb5/raw_testcase.py: Simplify conditionals
authorJoseph Sutton <josephsutton@catalyst.net.nz>
Tue, 15 Jun 2021 03:55:17 +0000 (15:55 +1200)
committerStefan Metzmacher <metze@samba.org>
Thu, 1 Jul 2021 17:46:31 +0000 (17:46 +0000)
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
python/samba/tests/krb5/raw_testcase.py

index ade980cb46dfca7f88fd12a8ae73148276409779..0e08f0ef7d21d01c15bb9fbbdd4f55dd9a6eb6ff 100644 (file)
@@ -437,9 +437,7 @@ class RawKerberosTest(TestCaseInTempDir):
                     allow_missing=False):
         val = None
         if prefix is not None:
-            allow_missing_prefix = allow_missing
-            if fallback_default:
-                allow_missing_prefix = True
+            allow_missing_prefix = allow_missing or fallback_default
             val = samba.tests.env_get_var_value('%s_%s' % (prefix, varname),
                                     allow_missing=allow_missing_prefix)
         else:
@@ -459,9 +457,7 @@ class RawKerberosTest(TestCaseInTempDir):
 
         domain = self.env_get_var('DOMAIN', prefix)
         realm = self.env_get_var('REALM', prefix)
-        allow_missing_username = False
-        if default_username is not None:
-            allow_missing_username = True
+        allow_missing_username = default_username is not None
         username = self.env_get_var('USERNAME', prefix,
                                     fallback_default=False,
                                     allow_missing=allow_missing_username)