]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
aarch64: Fix neon-sve-bridge.c failures for big-endian
authorRichard Sandiford <richard.sandiford@arm.com>
Mon, 21 Jul 2025 14:41:00 +0000 (15:41 +0100)
committerRichard Sandiford <richard.sandiford@arm.com>
Mon, 21 Jul 2025 14:41:00 +0000 (15:41 +0100)
Lowpart subregs are generally disallowed on big-endian SVE vector
registers, since the first memory element is stored at the least
significant end of the register, rather than the most significant end.
(See the comment at the head of aarch64-sve.md for details,
and aarch64_modes_compatible_p for the implementation.)

This means that arm_sve_neon_bridge.h needs to use custom define_insns
for big-endian targets, in lieu of using lowpart subregs.  However,
one of those define_insns relied on the prohibited lowparts internally,
to convert an Advanced SIMD register to an SVE register.  Since the
lowpart is not allowed, the lowpart_subreg would return null, leading
to a later ICE.

The simplest fix seems to be to use %Z instead, to force the Advanced
SIMD register to be written as an SVE register.

gcc/
* config/aarch64/aarch64-sve.md (@aarch64_sve_set_neonq_<mode>):
Use %Z instead of lowpart_subreg.  Tweak formatting.

(cherry picked from commit 69c839c7361430ec27d1f13f909531b872588f27)

gcc/config/aarch64/aarch64-sve.md

index 0728cccad4fbe1a10a94baa9f2709a475a5a5e7c..f8f744c263b9e8e19d6ad3dd08cec2992c8fdabf 100644 (file)
 
 (define_insn "@aarch64_sve_set_neonq_<mode>"
   [(set (match_operand:SVE_FULL 0 "register_operand" "=w")
-      (unspec:SVE_FULL
-       [(match_operand:SVE_FULL 1 "register_operand" "w")
-       (match_operand:<V128> 2 "register_operand" "w")
-       (match_operand:<VPRED> 3 "register_operand" "Upl")]
-       UNSPEC_SET_NEONQ))]
+       (unspec:SVE_FULL
+         [(match_operand:SVE_FULL 1 "register_operand" "w")
+          (match_operand:<V128> 2 "register_operand" "w")
+          (match_operand:<VPRED> 3 "register_operand" "Upl")]
+         UNSPEC_SET_NEONQ))]
   "TARGET_SVE
    && BYTES_BIG_ENDIAN"
-  {
-    operands[2] = lowpart_subreg (<MODE>mode, operands[2],
-                                  GET_MODE (operands[2]));
-    return "sel\t%0.<Vetype>, %3, %2.<Vetype>, %1.<Vetype>";
-  }
+  "sel\t%0.<Vetype>, %3, %Z2.<Vetype>, %1.<Vetype>"
 )