]> git.ipfire.org Git - thirdparty/vala.git/commitdiff
codegen: Add destroy out-param when invoking delegate returned by delegate
authorRico Tzschichholz <ricotz@ubuntu.com>
Sat, 6 Jan 2018 08:53:48 +0000 (09:53 +0100)
committerRico Tzschichholz <ricotz@ubuntu.com>
Sat, 6 Jan 2018 13:26:53 +0000 (14:26 +0100)
https://bugzilla.gnome.org/show_bug.cgi?id=792077

codegen/valaccodemethodcallmodule.vala
tests/Makefile.am
tests/delegates/bug792077.vala [new file with mode: 0644]

index acca4eddf1bd7b8148854210f5d3262eb30f0577..007bcbdee7ff9c8a1d1bcfa400a3b6ae83fa20b1 100644 (file)
@@ -598,6 +598,17 @@ public class Vala.CCodeMethodCallModule : CCodeAssignmentModule {
                                out_arg_map.set (get_param_pos (get_ccode_delegate_target_pos (deleg)), new CCodeUnaryExpression (CCodeUnaryOperator.ADDRESS_OF, temp_ref));
 
                                set_delegate_target (expr, temp_ref);
+
+                               if (deleg_type.is_disposable ()) {
+                                       temp_var = get_temp_variable (gdestroynotify_type);
+                                       temp_ref = get_variable_cexpression (temp_var.name);
+
+                                       emit_temp_var (temp_var);
+
+                                       out_arg_map.set (get_param_pos (get_ccode_delegate_target_pos (deleg) + 0.01), new CCodeUnaryExpression (CCodeUnaryOperator.ADDRESS_OF, temp_ref));
+
+                                       set_delegate_target_destroy_notify (expr, temp_ref);
+                               }
                        }
                }
 
index 10a62d56d72bf2e3e832b642df97bc872bcd416e..33750cb500950dd35f8b2a63fbde8ef769170bb4 100644 (file)
@@ -177,6 +177,7 @@ TESTS = \
        delegates/bug703804.vala \
        delegates/bug761360.vala \
        delegates/bug772204.test \
+       delegates/bug792077.vala \
        objects/chainup.vala \
        objects/classes.vala \
        objects/constructors.vala \
diff --git a/tests/delegates/bug792077.vala b/tests/delegates/bug792077.vala
new file mode 100644 (file)
index 0000000..4c29822
--- /dev/null
@@ -0,0 +1,16 @@
+delegate void FooFunc (int i);
+delegate FooFunc BarFunc ();
+
+int result = 0;
+
+void main () {
+       BarFunc func_gen = () => {
+               return (data) => {
+                       result = data;
+               };
+       };
+
+       FooFunc func = func_gen ();
+       func (42);
+       assert (result == 42);
+}