fix mypy errors

Change-Id: If49e0ff00f0b00ed914ddb8979ae49c3a8a10a0e

diff --git a/alembic/operations/batch.py b/alembic/operations/batch.py
index f5ff0bbab19808bface18ad429f0764cd957515d..ef182fdc7ac8a74de9ec120099bb985ad2c4fb39 100644 (file)
--- a/alembic/operations/batch.py
+++ b/alembic/operations/batch.py
@@ -466,9 +466,11 @@ class ApplyBatchImpl:
             if (
                 "existing_type" in kw
                 and isinstance(kw["existing_type"], SchemaEventTarget)
-                and kw["existing_type"].name
+                and kw["existing_type"].name  # type:ignore[attr-defined]
             ):
-                self.named_constraints.pop(kw["existing_type"].name, None)
+                self.named_constraints.pop(
+                    kw["existing_type"].name, None  # type:ignore[attr-defined]
+                )
 
         if type_ is not None:
             type_ = sqltypes.to_instance(type_)
@@ -590,9 +592,11 @@ class ApplyBatchImpl:
         if (
             "existing_type" in kw
             and isinstance(kw["existing_type"], SchemaEventTarget)
-            and kw["existing_type"].name
+            and kw["existing_type"].name  # type:ignore[attr-defined]
         ):
-            self.named_constraints.pop(kw["existing_type"].name, None)
+            self.named_constraints.pop(
+                kw["existing_type"].name, None  # type:ignore[attr-defined]
+            )
 
     def create_column_comment(self, column):
         """the batch table creation function will issue create_column_comment

diff --git a/alembic/util/compat.py b/alembic/util/compat.py
index d0e6672c5cf2ba19788dd6906357214507873138..1e435a829c568ceef55b0a7b309ac200b0eadf9d 100644 (file)
--- a/alembic/util/compat.py
+++ b/alembic/util/compat.py
@@ -27,12 +27,12 @@ class EncodedIO(io.TextIOWrapper):
 if py39:
     from importlib import resources as importlib_resources
 else:
-    import importlib_resources  # noqa
+    import importlib_resources  # type:ignore[no-redef] # noqa
 
 if py38:
     from importlib import metadata as importlib_metadata
 else:
-    import importlib_metadata  # noqa
+    import importlib_metadata  # type:ignore[no-redef] # noqa
 
 
 def importlib_metadata_get(group):

diff --git a/alembic/util/pyfiles.py b/alembic/util/pyfiles.py
index 3da32c3141b75b16c970faf1adb87899eb21d98f..b6662b716a2c1f11658206c36da8ea01e0f4460f 100644 (file)
--- a/alembic/util/pyfiles.py
+++ b/alembic/util/pyfiles.py
@@ -58,7 +58,7 @@ def coerce_resource_to_filename(fname: str) -> str:
         ref = compat.importlib_resources.files(tokens[0])
         for tok in tokens[1:]:
             ref = ref / tok
-        fname = file_manager.enter_context(
+        fname = file_manager.enter_context(  # type: ignore[assignment]
             compat.importlib_resources.as_file(ref)
         )
     return fname

diff --git a/setup.cfg b/setup.cfg
index 992a7ac4847f5b7a7b28acc0567f3b0ac584c4d1..d034e617266433ee1f64974933132af0c78bd3b2 100644 (file)
--- a/setup.cfg
+++ b/setup.cfg
@@ -127,3 +127,9 @@ ignore_missing_imports = True
 
 [mypy-sqlalchemy.testing.*]
 ignore_missing_imports = True
+
+[mypy-importlib_resources.*]
+ignore_missing_imports = True
+
+[mypy-importlib_metadata.*]
+ignore_missing_imports = True